testing - Dealing with code duplication in tests -


at work practice test driven development as possible. 1 thing end in though having set bunch of dto's , when these have complex structure becomes quite alot of code. problem code quite repettetive , feel distracts main purpose of test. instance using contrieved , condensed example (in java, junit + mockito):

class bookingservicetest {      private final static int hour_in_millis = 60 * 60 * 1000;     private final static int location_id = 1;     @mock     private bookinglocationdao bookinglocationdao;      @injectmocks     private bookingservice service = new bookingservice();      @test     public void yieldsawarningwhenabookingoverlapsanotherinthesamelocation() {         // part bit repetetive on many tests:         date = new date()         location location = new location()         location.setid(location_id);          booking existingbooking = new booking()         existingbooking.setstart(now);         existingbooking.setduration(hour_in_millis);         existingbooking.setlocation(location);         // here          when(bookinglocationdao.findbookingsatlocation(location_id))             .thenreturn(arrays.aslist(existingbooking));          // again setting booking :\         booking newbooking = new booking();         newbooking.setstart(now);         newbooking.setduration(hour_in_millis / 2);         newbooking.setlocation(location);                          // actual test...         bookingresult result = service.book(newbooking);          assertthat(result.getwarnings(), hassize(1));         assertthat(result.getwarnings().get(0).gettype(), is(bookingwarningtype.overlaping_booking));     }  }

in example setup not complicated wouldn't think of much. however, when more complicated input required code setup of input methods tend grow. problem gets exacerbated similar input being used in several tests. refactoring setup code separate testutil class helps bit. problem is bit hard find these utility classes when writing new tests couple of month's later, leads duplication.

  1. what way of dealing kind of "complex" dtos in order minimize code duplication in test setups?
  2. how ensure extracted testutilities found when working similar code?
  3. am doing wrong? :) should build software in way avoid situation altogether? if so, how?

as erik rightly points out used patterns solve testdatabuilder , objectmother. these covered in depth in: mark seemans advanced unit testing course growing object oriented software guided tests, both good.

in practice find test data builder pattern leads better, more readable tests objectmother pattern except in simplest cases (as need surprising number of overloads objectmother pattern).

another trick can use bunch sets of setups test object builder pattern single methods e.g.

invoice invoicewithnopostcode = new invoicebuilder()     .withrecipient(new recipientbuilder()         .withaddress(new addressbuilder()             .withnopostcode()             .build())         .build())     .build();

could become:

new invoicebuilder().withnopostcode().build();

and in cases can lead simpler test setups, doesn't work in cases.


Comments

Post a Comment

Popular posts from this blog

php - Why I am getting the Error "Commands out of sync; you can't run this command now" -

the documentation of error mentioned in title says if commands out of sync; can't run command now in client code, calling client functions in wrong order. this can happen, example, if using mysql_use_result() , try execute new query before have called mysql_free_result(). can happen if try execute 2 queries return data without calling mysql_use_result() or mysql_store_result() in between. from here: http://dev.mysql.com/doc/refman/5.0/en/commands-out-of-sync.html but in first query not fetching data mysql database, inserting. , in second query getting data database. here code $connection = mysqli_connect("localhost","username","password","tbl_msgs"); if(mysqli_connect_errno($connection)) { die("failed connect mysql: " . mysqli_connect_error()); } $query = "insert users (total_comments, total_views) values ({$total_comments}, {$total_views});"; $query .= "insert msgs (no...
Read more

linux - Does gcc have any options to add version info in ELF binary file? -

i mean whether gcc can insert source code version infor elf binary section or similar. not want change source file, add info gcc option in makefile. you can emit version info text file, turn text file object file statically link executable. the first step simple have write code: script or write version info in format plain text file. write makefile rule produce version.o version.txt, using objcopy . you'll have object file 2 useful symbols defined in it: beginning , end of textual version info. add generated object executable, , you'll able access version 2 ways: running strings on binary, or writing code in application print version string (you'll need declare start , end symbols variables in header file).
Read more

java - Are there any classes that implement javax.persistence.Parameter<T>? -

i'm using named queries fetch entities database using jpa , hibernate , came across puzzling me: how come there no default implementations of javax.persistence.parameter interface? i rather impressed how @staticmetamodel used criteriabuilder in jpa2 meaning type safety , don't have mess around setting string names. wanted apply similar of jpa1 ejb's i'm working on: dealergroup_.class: public dealergroup_ { public parameter<integer> id = new parameterimpl<integer>("id"); /// etc... } dealergroupfacade.class: // ... public dealergroup fetch(integer id) { typedquery<dealergroup> query = em.createnamedquery("dealergroup.fetchbyid", dealergroup.class); query.setparameter(dealergroup_.id, query); return query.getsingleresult(); } // ... i surprised find there no implementations of parameter interface - of course, implement myself absence makes me suspicious may mistake using in way? should implementing parameter...
Read more